Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/session token errors details #2747

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

carpawell
Copy link
Member

No description provided.

@carpawell carpawell self-assigned this Feb 21, 2024
@carpawell carpawell force-pushed the fix/session-token-errors-details branch from 7f66c57 to b5192c2 Compare February 21, 2024 20:47
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (06635c7) 28.87% compared to head (8858b30) 28.87%.
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/services/container/morph/executor.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2747   +/-   ##
=======================================
  Coverage   28.87%   28.87%           
=======================================
  Files         415      415           
  Lines       32478    32478           
=======================================
  Hits         9378     9378           
  Misses      22257    22257           
  Partials      843      843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carpawell carpawell force-pushed the fix/session-token-errors-details branch from b5192c2 to 76a150f Compare February 21, 2024 21:17
Now we have such errors: `code = 1024 message = session was not issued by the
container owner, issuer:
"52\n\xad\xc8\x18\x9f<\xf6V\x94\xf7î\xfd\xe1Ia\x05\xecӰ\xedE\x19"` but can do
it better for sure.

Signed-off-by: Pavel Karpy <[email protected]>
@carpawell carpawell force-pushed the fix/session-token-errors-details branch from 76a150f to 8858b30 Compare February 21, 2024 21:18
@roman-khimov roman-khimov merged commit 732d7c5 into master Feb 22, 2024
14 of 16 checks passed
@roman-khimov roman-khimov deleted the fix/session-token-errors-details branch February 22, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants