-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: add build/release workflow #2743
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
name: Build | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- master | ||
types: [opened, synchronize] | ||
paths-ignore: | ||
- 'config/**' | ||
- '**/*.md' | ||
push: | ||
# Build for the master branch. | ||
branches: | ||
- master | ||
release: | ||
# Publish released commit as Docker `latest` and `git_revision` images. | ||
types: | ||
- published | ||
workflow_dispatch: | ||
inputs: | ||
ref: | ||
description: 'Ref to build CLI [default: latest master; examples: v0.40.0, 0a4ff9d3e4a9ab432fd5812eb18c98e03b5a7432]' | ||
required: false | ||
default: '' | ||
push_image: | ||
description: 'Push images to DockerHub [default: false; examples: true, false]' | ||
required: false | ||
default: 'false' | ||
use_latest_tag: | ||
description: 'Use `latest` tag while pushing images to DockerHub [default: false; examples: true, false]' | ||
required: false | ||
default: 'false' | ||
|
||
jobs: | ||
build_bins: | ||
name: Build | ||
runs-on: ${{matrix.os.name}} | ||
strategy: | ||
matrix: | ||
os: [{ name: ubuntu-22.04, bin-name: linux }] # { name: windows-2022, bin-name: windows }, { name: macos-12, bin-name: darwin } | ||
arch: [amd64] # arm64 | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
ref: ${{ github.event.inputs.ref }} | ||
# Allows to fetch all history for all branches and tags. Need this for proper versioning. | ||
fetch-depth: 0 | ||
|
||
- name: Set up Go | ||
uses: actions/setup-go@v5 | ||
with: | ||
go-version: '1.21' | ||
cache: true | ||
|
||
- name: Build | ||
run: make | ||
env: | ||
GOARCH: ${{ matrix.arch }} | ||
|
||
- name: Rename binaries | ||
run: for i in ./bin/*; do mv $i $i-${{ matrix.os.bin-name }}-${{ matrix.arch }}${{ (matrix.os.bin-name == 'windows' && '.exe') || '' }}; done | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so we are changing our release binaries now? do we need to mention this (changelog?)? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They'll be exactly the same (that's why they're renamed) except for missing .tar.gz. I know .tar.gz is used in some cases, but those can be reworked and this duplication was never good. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the new "linux" word in the binary name? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check the binaries from https://github.com/nspcc-dev/neofs-node/actions/runs/7979125234?pr=2743, do we have correct number of linuxes there? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated CHANGELOG as well, btw. |
||
|
||
- name: Upload artifacts | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: Binaries ${{ matrix.os.bin-name }}-${{ matrix.arch }} | ||
path: ./bin/* | ||
if-no-files-found: error | ||
|
||
- name: Attach binaries to the release as assets | ||
if: ${{ github.event_name == 'release' }} | ||
run: gh release upload ${{ github.event.release.tag_name }} ./bin/* | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
build_images: | ||
needs: build_bins | ||
name: Build and push docker images | ||
runs-on: ubuntu-22.04 | ||
strategy: | ||
matrix: | ||
image: [adm, cli, ir, storage] | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
ref: ${{ github.event.inputs.ref }} | ||
fetch-depth: 0 | ||
|
||
- name: Set up QEMU | ||
uses: docker/setup-qemu-action@v3 | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v3 | ||
|
||
- name: Login to DockerHub | ||
if: ${{ github.event_name == 'release' || (github.event_name == 'workflow_dispatch' && github.event.inputs.push_image == 'true') }} | ||
uses: docker/login-action@v3 | ||
with: | ||
username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
password: ${{ secrets.DOCKERHUB_PASSWORD }} | ||
|
||
- name: Set version | ||
id: setver | ||
run: echo version=`make version` >> $GITHUB_OUTPUT | ||
|
||
- name: Set latest tag | ||
id: setlatest | ||
if: ${{ (github.event_name == 'release' && github.event.release.target_commitish == 'master') || (github.event_name == 'workflow_dispatch' && github.event.inputs.use_latest_tag == 'true') }} | ||
run: echo "latest=,nspccdev/neofs-${{matrix.image}}:latest" >> $GITHUB_OUTPUT | ||
|
||
- name: Build and push image | ||
uses: docker/build-push-action@v5 | ||
with: | ||
context: . | ||
file: .docker/Dockerfile.${{matrix.image}} | ||
push: ${{ github.event_name == 'release' || (github.event_name == 'workflow_dispatch' && github.event.inputs.push_image == 'true') }} | ||
platforms: linux/amd64 | ||
build-args: | | ||
REPO=github.com/${{ github.repository }} | ||
VERSION=${{ steps.setver.outputs.version }} | ||
tags: nspccdev/neofs-${{matrix.image}}:${{ steps.setver.outputs.version }}${{ steps.setlatest.outputs.latest }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it means the latest one we adopted? so after the #2738 it gonna be 1.22?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, as usual. Except that 1.22 will be added when we're to drop 1.20, not when it's the minimal one (go.mod).