morph: Try all endpoints on client creation #2705
Conversation
carpawell
requested review from
roman-khimov and
cthulhu-rider
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2705 +/- ##
==========================================
- Coverage 28.79% 28.78% -0.01%
==========================================
Files 415 415
Lines 32371 32375 +4
==========================================
- Hits 9321 9319 -2
- Misses 22216 22221 +5
- Partials 834 835 +1 ☔ View full report in Codecov by Sentry. |
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ Changelog for NeoFS Node | |||
| ### Added | |||
|
|
|||
| ### Fixed | |||
| - Morph client dies when the first endpoint is unavailable even if there are more endpoints to try (#2703) | |||
There was a problem hiding this comment.
can be confusing: is it about what was fixed or after changes? from now / no more help
and Morph client -> NeoFS chain connection
There was a problem hiding this comment.
is it about what was fixed or after changes?
it always bothers me when i fill Fixed. i came to a mentioning a problem itself (so every point here describes not expected things)
from now/no morehelp
i can understand you but not sure we want to see hundreds of from now it this file. mb we need to find some common approach or try to paraphrase it. @roman-khimov
and Morph client -> NeoFS chain connection
this is a common chain client
There was a problem hiding this comment.
fixed smth, like "RPC client failure when..."
There was a problem hiding this comment.
agree, fixed. but still think that we need to have some common behavior pattern here. a headache every time I need to expand this section even if I really want it to be clear
still think "... failure ..." can be understood differently. is it a new expected failure or we have fixed some unexpected failure?
carpawell
force-pushed
the
fix/morph-creation-with-multiple-endpoits
branch
from
4e9e3e8 to
8a9a185
Compare
Do not fail if the first one is unavailable but more endpoints are provided. Closes #2703. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/morph-creation-with-multiple-endpoits
branch
from
8a9a185 to
0d08b51
Compare
Do not fail if the first one is unavailable but more endpoints are provided.