Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytes.Clone for slice copying #2251

Closed
roman-khimov opened this issue Feb 9, 2023 · 0 comments
Closed

bytes.Clone for slice copying #2251

roman-khimov opened this issue Feb 9, 2023 · 0 comments
Assignees
@cthulhu-rider
Labels
enhancement Improving existing functionality go Go language related I4 No visible changes S2 Regular significance U4 Nothing urgent
Milestone
v0.41.0

Comments

@roman-khimov
Copy link
Member

Go 1.20 finally brought to us a killer feature --- bytes.Clone library function that can... copy byte slices! We can finally replace slice.Copy (but not a `slice.CopyReverse, ha-ha) with something standard.
@roman-khimov roman-khimov added refactor go Go language related labels Feb 9, 2023
@roman-khimov roman-khimov mentioned this issue Feb 9, 2023
Closed
@roman-khimov roman-khimov mentioned this issue Aug 9, 2023
Merged
3 tasks
@roman-khimov roman-khimov added enhancement Improving existing functionality U4 Nothing urgent S2 Regular significance I4 No visible changes blocked Can't be done because of something and removed refactor labels Dec 21, 2023
@roman-khimov roman-khimov removed the blocked Can't be done because of something label Feb 11, 2024
@roman-khimov roman-khimov added this to the v0.41.0 milestone Feb 11, 2024
@cthulhu-rider cthulhu-rider self-assigned this Feb 27, 2024
cthulhu-rider added a commit that referenced this issue Feb 27, 2024
@cthulhu-rider
*: Replace slice.Copy with bytes.Clone
e6a33b5 
New stdlib function was introduced in Go 1.20 and completely replaces
the previously used utility.

Closes #2251.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this issue Feb 28, 2024
@cthulhu-rider
*: Use bytes.Clone to copy byte slices
36789a8 
New stdlib function was introduced in Go 1.20. It completely replaces
the previously used `slice.Copy` utility. Manual `make`+`copy` no longer
needed too.

Closes #2251.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this issue Feb 29, 2024
@cthulhu-rider
*: Use bytes.Clone to copy byte slices
54cb45c 
New stdlib function was introduced in Go 1.20. It completely replaces
the previously used `slice.Copy` utility. Manual `make`+`copy` no longer
needed too.

Closes #2251.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this issue Feb 29, 2024
@cthulhu-rider
*: Use bytes.Clone to copy byte slices
66f6ab4 
New stdlib function was introduced in Go 1.20. It completely replaces
the previously used `slice.Copy` utility. Manual `make`+`copy` no longer
needed too.

Closes #2251.

Signed-off-by: Leonard Lyubich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-rider cthulhu-rider

Labels
enhancement Improving existing functionality go Go language related I4 No visible changes S2 Regular significance U4 Nothing urgent
Projects
None yet
Milestone
v0.41.0
Development

No branches or pull requests
2 participants
@roman-khimov @cthulhu-rider