NNS wrapper extensions #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can be convenient for non-standard names (netmap.neofs vs contract.smth). Signed-off-by: Roman Khimov <[email protected]>
rpc/nns/hashes.go
Outdated
| } | ||
|
|
||
| // NewFS creates an instance of [Contract] using hash obtained via [InferHash]. | ||
| func NewFS(sg ContractStateGetter, actor Actor) (*Contract, error) { |
There was a problem hiding this comment.
confusing name to me, i suggest
Suggested change
| func NewFS(sg ContractStateGetter, actor Actor) (*Contract, error) { | |
| func NewInferred(sg ContractStateGetter, actor Actor) (*Contract, error) { |
or
Suggested change
| func NewFS(sg ContractStateGetter, actor Actor) (*Contract, error) { | |
| func NewWithInferredHash(sg ContractStateGetter, actor Actor) (*Contract, error) { |
There was a problem hiding this comment.
Yeah, I had some doubts about it as well, but decided to try with a shorter one. @carpawell, what'd be your preference?
There was a problem hiding this comment.
yes, i would die if i did not know what and why FS is here. NewInferred and NewWithInferredHash are not perfect to me either but better
If just need a ContractReader this simplifies things somewhat. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
nns-extensions
branch
from
a3640ef to
1bcacce
Compare
carpawell
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by nspcc-dev/neofs-node#2841.