Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move contract deployment/update code into this repository #394

Closed
roman-khimov opened this issue Apr 16, 2024 · 0 comments · Fixed by #395
Closed

Move contract deployment/update code into this repository #394

roman-khimov opened this issue Apr 16, 2024 · 0 comments · Fixed by #395
Assignees
@smallhive
Labels
feature Completely new functionality I1 High impact S1 Highly significant U2 Seriously planned
Milestone
v0.20.0

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when we can't reuse deployment/update code in various projects. It was added into node in nspcc-dev/neofs-node#2195, but you can't deploy additional contracts this way.

Describe the solution you'd like

Port this code into a library here. Add some tests for it.

Additional context

#384.
@roman-khimov roman-khimov added U2 Seriously planned S1 Highly significant I1 High impact feature Completely new functionality labels Apr 16, 2024
@roman-khimov roman-khimov added this to the v0.20.0 milestone Apr 16, 2024
smallhive added a commit that referenced this issue Apr 18, 2024
@smallhive
deploy: Move system contracts deploy
c67c53c 
Closes #394.

Signed-off-by: Evgenii Baidakov <[email protected]>
This was referenced Apr 18, 2024
Merged
Closed
smallhive added a commit that referenced this issue Apr 27, 2024
@smallhive
deploy: Move system contracts deploy
47b567d 
Closes #394.

Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive added a commit that referenced this issue Apr 27, 2024
@smallhive
deploy: Move system contracts deploy
f461d70 
Closes #394.

Signed-off-by: Evgenii Baidakov <[email protected]>
roman-khimov added a commit that referenced this issue Apr 27, 2024
@roman-khimov
Move contract deployment (#395)
286b141 
Closes #394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smallhive smallhive

Labels
feature Completely new functionality I1 High impact S1 Highly significant U2 Seriously planned
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging a pull request may close this issue.

Move contract deployment nspcc-dev/neofs-contract
2 participants
@smallhive @roman-khimov