netmap: Add reserved node attribute for verified nodes' domain #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
requested review from
carpawell and
roman-khimov
as code owners
roman-khimov
previously approved these changes
Sep 26, 2023
carpawell
previously approved these changes
Sep 26, 2023
Sometimes there is a need to control the entry of some storage nodes into a certain group at the stage of registration in the NeoFS network. For example, a specific organization may wish to be part of a public network, but limit the ability of a third party to indicate its affiliation. Previously, any candidate node could specify any valid attribute making private node group (aka subnet) not implementable. This commit reserves node attribute with key `VerifiedNodesDomain`. From now, any storage attempting to enter the NeoFS network and declaring this attribute will have to confirm its right to do so. This feature will allow parties to organize subgroups of nodes (i.e. subnets) and control access to them. While new changes impose requirements and are technically not backwards compatible, the use of the new attribute has never been observed in practice. It's worth noting that omitting is backwards compatible. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
dismissed stale reviews from carpawell and roman-khimov
via
d542954
cthulhu-rider
force-pushed
the
feature/verified-nodes
branch
from
cd73abd
to
d542954
Compare
roman-khimov
approved these changes
Sep 27, 2023
carpawell
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by nspcc-dev/neofs-node#2280