refs: Change support for different signature schemes #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
pushed a commit
to cthulhu-rider/neofs-api
that referenced
this pull request
Mar 2, 2022
Remove `UNSPECIFIED` value from `SignatureScheme` enum. Make `ECDSA_SHA512` to be default signature scheme (zero value). Define `SignatureRFC6979` type for RFC-6979 signatures. Use it in `Container` service. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
fix/signatures
branch
from
53e0654
to
d39ace4
Compare
added 2 commits
March 2, 2022 12:34
Remove `UNSPECIFIED` value from `SignatureScheme` enum. Make `ECDSA_SHA512` to be default signature scheme (zero value). Define `SignatureRFC6979` type for RFC-6979 signatures. Use it in `Container` service. Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
fix/signatures
branch
from
d39ace4
to
ad9cd50
Compare
alexvanin
approved these changes
Mar 2, 2022
fyrchik
approved these changes
Mar 2, 2022
|
May I ask why we need |
|
It is not true for container creation operation. Container creation operation requires only To stress that in protocol, we have separate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
UNSPECIFIEDvalue fromSignatureSchemeenum. MakeECDSA_SHA512to be default signature scheme (zero value).Define
SignatureRFC6979type for RFC-6979 signatures. Use it inContainerservice.Signed-off-by: Leonard Lyubich [email protected]