Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce response status errors #176

Merged

Conversation

cthulhu-rider
Copy link
Contributor

Related #150.

Docs will be added right after structural finalization.

@cthulhu-rider cthulhu-rider self-assigned this Oct 4, 2021
@cthulhu-rider cthulhu-rider force-pushed the feature/150-response-status branch 2 times, most recently from 29c2009 to 4e9864b Compare November 6, 2021 13:10
Copy link
Contributor

@alexvanin alexvanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is time to merge it finally.

accounting/service.proto Outdated Show resolved Hide resolved
object/service.proto Outdated Show resolved Hide resolved
proto-docs/container.md Outdated Show resolved Hide resolved
proto-docs/object.md Outdated Show resolved Hide resolved
proto-docs/status.md Outdated Show resolved Hide resolved
proto-docs/status.md Outdated Show resolved Hide resolved
proto-docs/status.md Outdated Show resolved Hide resolved
proto-docs/status.md Outdated Show resolved Hide resolved
@cthulhu-rider cthulhu-rider force-pushed the feature/150-response-status branch 2 times, most recently from cc7af00 to c3e3080 Compare November 15, 2021 12:10
Copy link

@realloc realloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in spec pdf

session/types.proto Outdated Show resolved Hide resolved
status/types.proto Outdated Show resolved Hide resolved
status/types.proto Outdated Show resolved Hide resolved
status/types.proto Outdated Show resolved Hide resolved
@carpawell
Copy link
Member

carpawell commented Nov 15, 2021

Can you, please, clarify to me (not in code) how to interpret such common comments:

  // Statuses:
  // - **OK** (0, SECTION_SUCCESS):
  // balance has been successfully read;
  // - Common failures (SECTION_FAILURE_COMMON).

@cthulhu-rider
Copy link
Contributor Author

@carpawell, common scheme is:

- <code_name> (<global_code>, <section_name>): <desc>

Сommon failures are special: they apply equally to all operations. It is inconvenient to copy them in manual mode, and there is no autogeneration, at least not yet. Therefore, the description of the codes of this section should be found in the place of their definition.

@cthulhu-rider cthulhu-rider merged commit 7ea5a1d into nspcc-dev:master Nov 16, 2021
@cthulhu-rider cthulhu-rider deleted the feature/150-response-status branch November 16, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe error handling in RPC responses
5 participants