Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand NetworkInfo information with more data #172

Closed
alexvanin opened this issue Sep 8, 2021 · 3 comments · Fixed by #174
Closed

Expand NetworkInfo information with more data #172

alexvanin opened this issue Sep 8, 2021 · 3 comments · Fixed by #174
Assignees
@cthulhu-rider
Milestone
v2.10.0

Comments

@alexvanin
Copy link
Contributor

After nspcc-dev/neo-go#2160 we can expand NetworkInfo message with details about side chain:

  • Ms per block,
  • ... ?

Also we can include NeoFS global configuration records as a list of key/value (both repeated bytes).
Keys are hex encoded strings and values ara raw data from netmap contract.
This was referenced Sep 8, 2021
Closed
Closed
@cthulhu-rider cthulhu-rider self-assigned this Sep 15, 2021
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api that referenced this issue Sep 15, 2021
[nspcc-dev#172] netmap: Add ms_per_block field to NetworkInfo message
ea9906c 
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api that referenced this issue Sep 15, 2021
[nspcc-dev#172] netmap: Define NetworkConfig message
ad1ed0f 
Define `netmap.NetworkConfig` message which represents structure of
NeoFS network config stored in Netmap contract.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api that referenced this issue Sep 15, 2021
[nspcc-dev#172] netmap: Add network configuration to NetworkInfo message
9c48507 
Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Sep 15, 2021 •
edited
Loading

I'd also document list of keys and format of corresponding values.

cthulhu-rider pushed a commit to cthulhu-rider/neofs-api that referenced this issue Sep 15, 2021
[nspcc-dev#172] netmap: Define NetworkConfig message
cc2940b 
Define `netmap.NetworkConfig` message which represents structure of
NeoFS network config stored in Netmap contract.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api that referenced this issue Sep 15, 2021
[nspcc-dev#172] netmap: Add network configuration to NetworkInfo message
3e4cc5e 
Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider mentioned this issue Sep 15, 2021
Merged
@cthulhu-rider
Copy link
Contributor

@alexvanin are u sure that keys are hex-encoded strings? Seems like Netmap contract stores UTF-8 strings. Or we want to encode them during communication?

@alexvanin
Copy link
Contributor Author

@alexvanin are u sure that keys are hex-encoded strings? Seems like Netmap contract stores UTF-8 strings. Or we want to encode them during communication?

You are right, they are simple UTF-8 encoded strings and should stay this way.

cthulhu-rider pushed a commit to cthulhu-rider/neofs-api that referenced this issue Sep 15, 2021
[nspcc-dev#172] netmap: Add ms_per_block field to NetworkInfo message
ec2b034 
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api that referenced this issue Sep 15, 2021
[nspcc-dev#172] netmap: Define NetworkConfig message
132b7e1 
Define `netmap.NetworkConfig` message which represents structure of
NeoFS network config stored in Netmap contract.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api that referenced this issue Sep 15, 2021
[nspcc-dev#172] netmap: Add network configuration to NetworkInfo message
d20745a 
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api that referenced this issue Sep 24, 2021
[nspcc-dev#172] netmap: Define NetworkConfig message
39c0798 
Define `netmap.NetworkConfig` message which represents structure of
NeoFS network config stored in Netmap contract.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api that referenced this issue Sep 24, 2021
[nspcc-dev#172] netmap: Add network configuration to NetworkInfo message
9dd73ff 
Signed-off-by: Leonard Lyubich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-rider cthulhu-rider

Labels
None yet
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging a pull request may close this issue.

Expand netmap.NetworkInfo cthulhu-rider/neofs-api
2 participants
@alexvanin @cthulhu-rider