vm: fix incorrect refcounting in POPITEM #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're popping an item (array) off the stack, OK, it triggers refs.Remove() for it. Then we're pushing an inner item to the stack, OK, it triggers refs.Add() for this element. Why are we removing it afterwards? Looks like something went wrong in 324107b (and #1670) since a simple test shows zero counter after POPITEM and -1 after popping the only item left on the stack. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
added
bug
14 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3688 +/- ##
==========================================
+ Coverage 83.00% 83.06% +0.05%
==========================================
Files 334 334
Lines 46629 46628 -1
==========================================
+ Hits 38706 38731 +25
+ Misses 6348 6319 -29
- Partials 1575 1578 +3 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
approved these changes
Nov 18, 2024
| @@ -1459,7 +1459,6 @@ func (v *VM) execute(ctx *Context, op opcode.Opcode, parameter []byte) (err erro | |||
| case *stackitem.Struct: | |||
| item.Remove(index) | |||
| } | |||
| v.refs.Remove(elem) | |||
There was a problem hiding this comment.
It even had a separate designated review comment (324107b#r559602943), but I'm also not sure why this line was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're popping an item (array) off the stack, OK, it triggers refs.Remove() for it. Then we're pushing an inner item to the stack, OK, it triggers refs.Add() for this element. Why are we removing it afterwards? Looks like something went wrong in 324107b (and #1670) since a simple test shows zero counter after POPITEM and -1 after popping the only item left on the stack.