cli: add debug mode to upload-bin
#3672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3672 +/- ##
==========================================
+ Coverage 83.04% 83.07% +0.03%
==========================================
Files 334 334
Lines 46613 46623 +10
==========================================
+ Hits 38708 38732 +24
+ Misses 6333 6313 -20
- Partials 1572 1578 +6 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Nov 11, 2024
AnnaShaleva
reviewed
Nov 15, 2024
cli/util/upload_bin.go
Outdated
| if errUpload != nil { | ||
| return errUpload | ||
| } | ||
| fmt.Fprintf(ctx.App.Writer, "Uploaded block %d with object ID: %s\n", blockIndex, resOid.String()) |
There was a problem hiding this comment.
Let's move it under --debug, d flag, these logs are useful. By default we don't want these logs to be enabled, but it's a nice opportunity to have them in debug mode.
There was a problem hiding this comment.
only for blocks?
There was a problem hiding this comment.
Removed index files OIDs logging.
Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
uploader-verbose
branch
from
067af5b to
0fd9717
Compare
AliceInHunterland
changed the title
upload-bin for testing purposesupload-bin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs. #3658 (comment)