Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC wrapper for simple arrays #2792

Merged
merged 2 commits into from
Nov 15, 2022
Merged

RPC wrapper for simple arrays #2792

merged 2 commits into from
Nov 15, 2022

Conversation

roman-khimov
Copy link
Member

No description provided.

@roman-khimov roman-khimov added compiler Go smart contract compiler rpc RPC server and client labels Nov 14, 2022
@roman-khimov roman-khimov added this to the v0.100.0 milestone Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #2792 (82c6ce2) into master (f78231f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
+ Coverage   84.80%   84.85%   +0.04%     
==========================================
  Files         327      327              
  Lines       41243    41358     +115     
==========================================
+ Hits        34978    35095     +117     
+ Misses       4834     4831       -3     
- Partials     1431     1432       +1     
Impacted Files Coverage Δ
pkg/rpcclient/unwrap/unwrap.go 100.00% <100.00%> (ø)
pkg/smartcontract/rpcbinding/binding.go 92.18% <100.00%> (+5.39%) ⬆️
cli/server/server.go 72.24% <0.00%> (-0.80%) ⬇️
pkg/network/server.go 72.78% <0.00%> (+0.30%) ⬆️
pkg/network/compress.go 76.00% <0.00%> (+12.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another issue I'm thinking about is that array of something can be naturally substituted by Null stackitem and our unwrappers won't accept it. Maybe it's worth to add Null support to unwrap package for arrays?

pkg/rpcclient/unwrap/unwrap.go Show resolved Hide resolved
pkg/smartcontract/rpcbinding/binding.go Show resolved Hide resolved
@AnnaShaleva
Copy link
Member

Another issue I'm thinking about is that array of something can be naturally substituted by Null stackitem and our unwrappers won't accept it. Maybe it's worth to add Null support to unwrap package for arrays?

If we don't want to add Null unwrappers then LGTM.

@roman-khimov roman-khimov merged commit c67ee54 into master Nov 15, 2022
@roman-khimov roman-khimov deleted the rpcwrapper-arrays branch November 15, 2022 06:08
@roman-khimov roman-khimov modified the milestones: v0.100.0, v0.99.6 Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Go smart contract compiler rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants