Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: NNS update, part 1 #2679

Merged
merged 4 commits into from
Sep 16, 2022
Merged

examples: NNS update, part 1 #2679

merged 4 commits into from
Sep 16, 2022

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Sep 5, 2022 •
edited
Loading

@AnnaShaleva AnnaShaleva marked this pull request as draft September 5, 2022 14:33
@AnnaShaleva AnnaShaleva marked this pull request as ready for review September 6, 2022 10:38
@AnnaShaleva
Copy link
Member Author

neo-project/non-native-contracts#23 is linked.

@codecov
Copy link

codecov bot commented Sep 6, 2022 •
edited
Loading

Codecov Report

Merging #2679 (4543de0) into master (20224cb) will increase coverage by 0.20%.
The diff coverage is n/a.

❗ Current head 4543de0 differs from pull request most recent head 94852ab. Consider uploading reports for the commit 94852ab to get more accurate results

@@            Coverage Diff             @@
##           master    #2679      +/-   ##
==========================================
+ Coverage   85.23%   85.44%   +0.20%     
==========================================
  Files         322      322              
  Lines       39398    39655     +257     
==========================================
+ Hits        33580    33882     +302     
+ Misses       4479     4445      -34     
+ Partials     1339     1328      -11
Impacted Files Coverage Δ
pkg/services/stateroot/network.go 76.71% <0.00%> (-0.32%) ⬇️
pkg/services/oracle/response.go 84.80% <0.00%> (-0.24%) ⬇️
pkg/network/server.go 73.08% <0.00%> (-0.17%) ⬇️
pkg/neorpc/errors.go 69.69% <0.00%> (ø)
pkg/rpcclient/nep11.go 0.00% <0.00%> (ø)
pkg/consensus/crypto.go 100.00% <0.00%> (ø)
pkg/util/slice/array.go 100.00% <0.00%> (ø)
pkg/services/metrics/metrics.go 68.42% <0.00%> (ø)
pkg/core/storage/leveldb_store.go 74.32% <0.00%> (ø)
cli/smartcontract/smart_contract.go 93.20% <0.00%> (+0.02%) ⬆️
... and 25 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnnaShaleva AnnaShaleva mentioned this pull request Sep 9, 2022
Draft
roman-khimov
roman-khimov reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be equivalent to neo-project/non-native-contracts#23, can we only have here things that are a part of it? TLD/admin/expiration checks are all from different patch sets.

examples/nft-nd-nns/nns.go Outdated Show resolved Hide resolved
examples/nft-nd-nns/nns_test.go Show resolved Hide resolved
@AnnaShaleva
Copy link
Member Author

TLD/admin/expiration checks are all from different patch sets.

For C# set of PRs I've changed the order of TLD/expiration commits which results in a painful rebase, because these commits are tightly related. Am I supposed to perform the same thing for us?

@AnnaShaleva
Copy link
Member Author

Ready for review.

@roman-khimov
Copy link
Member

TLD is very invasive, we need to wait for C# PRs on this then.

@roman-khimov roman-khimov merged commit 1f94ebe into master Sep 16, 2022
@roman-khimov roman-khimov deleted the nns-upd branch September 16, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@fyrchik fyrchik Awaiting requested review from fyrchik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnnaShaleva @roman-khimov