-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: several Notary subsystem adjustments, part 1 #2378
Conversation
24cf239
to
ff4b2a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be split into two PRs: one that we can merge immediately (everything related to NotaryServiceFeePerKey and fixes) and one that'd be postponed until final agreement is reached (IDs mostly, but withdrawal changes too).
1cc3963
to
78f2998
Compare
24974d5
to
5740766
Compare
* Add corresponding methods to Notary contract. * Extend RPC Client API. * Adjust tests.
5740766
to
992d74d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2378 +/- ##
==========================================
+ Coverage 84.87% 84.97% +0.09%
==========================================
Files 290 290
Lines 35930 36050 +120
==========================================
+ Hits 30496 30632 +136
+ Misses 4143 4119 -24
- Partials 1291 1299 +8
Continue to review full report at Codecov.
|
Changes should be in sync with neo-project/neo#2661 and neo-project/neo-modules#691.