Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: use proper types in manifest #1820

Merged
merged 1 commit into from
Mar 11, 2021
Merged

native: use proper types in manifest #1820

merged 1 commit into from
Mar 11, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Mar 5, 2021

Close #1816 .

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #1820 (1cb25d3) into master (75ec20b) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1820      +/-   ##
==========================================
- Coverage   83.44%   83.38%   -0.06%     
==========================================
  Files         281      281              
  Lines       22353    22353              
==========================================
- Hits        18653    18640      -13     
- Misses       2556     2572      +16     
+ Partials     1144     1141       -3     
Impacted Files Coverage Δ
pkg/core/native/native_neo.go 72.82% <100.00%> (ø)
pkg/core/native/nonfungible.go 82.17% <100.00%> (ø)
pkg/services/oracle/oracle.go 78.82% <0.00%> (-11.77%) ⬇️
pkg/services/oracle/request.go 53.03% <0.00%> (-4.55%) ⬇️
pkg/network/server.go 71.36% <0.00%> (+0.14%) ⬆️
pkg/consensus/consensus.go 68.98% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ec20b...1cb25d3. Read the comment docs.

@roman-khimov
Copy link
Member

Is it a draft still?

@roman-khimov roman-khimov merged commit 096f48c into master Mar 11, 2021
@roman-khimov roman-khimov deleted the fix/nativetypes branch March 11, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix native contract types
2 participants