-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ConsensusData
from Block
#1792
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1792 +/- ##
==========================================
- Coverage 83.61% 83.52% -0.10%
==========================================
Files 284 283 -1
Lines 22099 22166 +67
==========================================
+ Hits 18479 18514 +35
- Misses 2492 2523 +31
- Partials 1128 1129 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first two commits don't belong here.
First commits are needed to correctly regenerate testchain, this wasn't catched when bug was introduced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It'd be nice to rename
block_base.go
intoheader.go
(*Blockchain).GetBlock
should fail for incomplete block, we can do that with merkle root check, for empty block it'd be 0 (and thusblock == header
), for non-empty block it won't be 0 and we should then check for number of transactions (that should also not be zero, otherwise we only have header and can't answerGetBlock
request).
Allow to convert to both `Buffer` and `ByteString` and explicitly mention VM types. Rename `ToByteArray` to `ToBytes` to avoid ambiguity.
Close #1738 .