Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: fix NEP17.Transfer cost #1617

Merged
merged 1 commit into from
Dec 15, 2020
Merged

native: fix NEP17.Transfer cost #1617

merged 1 commit into from
Dec 15, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Dec 15, 2020

It was increased with the introducion of postTransfer.

It was increased with the introducion of `postTransfer`.
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #1617 (5310c7f) into master (f009e53) will increase coverage by 7.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
+ Coverage   75.43%   82.53%   +7.09%     
==========================================
  Files         241      241              
  Lines       19022    19022              
==========================================
+ Hits        14349    15699    +1350     
+ Misses       3845     2339    -1506     
- Partials      828      984     +156     
Impacted Files Coverage Δ
pkg/core/native/native_nep17.go 74.53% <100.00%> (+1.24%) ⬆️
pkg/network/metrics/metrics.go 63.63% <0.00%> (-18.19%) ⬇️
pkg/compiler/codegen.go 90.55% <0.00%> (+0.39%) ⬆️
pkg/vm/stackitem/item.go 90.36% <0.00%> (+0.48%) ⬆️
pkg/rpc/server/server.go 77.45% <0.00%> (+0.55%) ⬆️
pkg/compiler/debug.go 92.79% <0.00%> (+0.90%) ⬆️
pkg/rpc/client/rpc.go 87.18% <0.00%> (+0.93%) ⬆️
pkg/vm/vm.go 93.88% <0.00%> (+1.06%) ⬆️
pkg/core/blockchain.go 76.71% <0.00%> (+1.10%) ⬆️
pkg/core/native/native_neo.go 70.32% <0.00%> (+1.15%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f009e53...5310c7f. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.92.0 milestone Dec 15, 2020
@roman-khimov roman-khimov merged commit 42be00b into master Dec 15, 2020
@roman-khimov roman-khimov deleted the fix/transfer branch December 15, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants