Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delegated voting #1252

Merged
merged 11 commits into from
Aug 7, 2020
Merged

Implement delegated voting #1252

merged 11 commits into from
Aug 7, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Aug 3, 2020

Close #867 .
Close #1206 .

Tested voting CLI on single node via getvalidators RPC.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #1252 into master will increase coverage by 6.81%.
The diff coverage is 47.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   61.26%   68.07%   +6.81%     
==========================================
  Files         216      217       +1     
  Lines       18490    18558      +68     
==========================================
+ Hits        11328    12634    +1306     
+ Misses       6542     5235    -1307     
- Partials      620      689      +69     
Impacted Files Coverage Δ
cli/wallet/wallet.go 0.00% <0.00%> (ø)
pkg/core/native/native_gas.go 69.69% <0.00%> (ø)
pkg/core/native/validators_count.go 0.00% <ø> (ø)
pkg/rpc/client/nep5.go 3.60% <0.00%> (+3.60%) ⬆️
pkg/core/state/native_state.go 72.60% <46.66%> (-7.73%) ⬇️
pkg/core/util.go 76.76% <60.00%> (-2.59%) ⬇️
pkg/core/native/native_neo.go 55.51% <61.00%> (+20.95%) ⬆️
pkg/core/blockchain.go 66.70% <66.66%> (+1.79%) ⬆️
pkg/core/native/native_neo_candidate.go 82.60% <82.60%> (ø)
pkg/core/native/native_nep5.go 72.88% <88.88%> (+1.69%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d3223...3a67964. Read the comment docs.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to differentiate GetStandbyValidators from GetStandbyCommittee in Blockchain API. We'll have more members in standby committee soon.

pkg/core/native/native_neo.go Show resolved Hide resolved
pkg/rpc/server/server_test.go Show resolved Hide resolved
pkg/core/util.go Outdated Show resolved Hide resolved
pkg/core/helper_test.go Outdated Show resolved Hide resolved
pkg/core/util.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
@roman-khimov roman-khimov merged commit d571162 into master Aug 7, 2020
@roman-khimov roman-khimov deleted the fix/voting branch August 7, 2020 07:38
roman-khimov added a commit that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement voting CLI commands Implement delegated voting
3 participants