Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: implement key recover interops #1006

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Conversation

AnnaShaleva
Copy link
Member

closes #1003

@AnnaShaleva AnnaShaleva requested a review from roman-khimov June 1, 2020 06:03
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #1006 into neox-2.x will increase coverage by 0.05%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           neox-2.x    #1006      +/-   ##
============================================
+ Coverage     68.79%   68.84%   +0.05%     
============================================
  Files           154      154              
  Lines         14907    14975      +68     
============================================
+ Hits          10255    10310      +55     
- Misses         4178     4185       +7     
- Partials        474      480       +6     
Impacted Files Coverage Δ
pkg/core/interops.go 94.59% <ø> (ø)
pkg/core/interop_neo.go 58.05% <82.35%> (+0.78%) ⬆️
pkg/crypto/keys/publickey.go 83.48% <83.60%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f90a06...6c06bc5. Read the comment docs.

@AnnaShaleva AnnaShaleva force-pushed the interop/crypto branch 4 times, most recently from a0128fa to 2b27ee4 Compare June 2, 2020 11:34
@AnnaShaleva AnnaShaleva changed the base branch from master-2.x to neox-2.x June 2, 2020 11:34
@AnnaShaleva AnnaShaleva force-pushed the interop/crypto branch 3 times, most recently from ed43523 to c5e2319 Compare June 2, 2020 15:01
@AnnaShaleva AnnaShaleva marked this pull request as ready for review June 2, 2020 15:05
pkg/core/interop_neo.go Show resolved Hide resolved
pkg/core/interop_neo_test.go Outdated Show resolved Hide resolved
fyrchik
fyrchik previously requested changes Jun 2, 2020
pkg/crypto/keys/publickey_test.go Show resolved Hide resolved
pkg/core/interop_neo.go Outdated Show resolved Hide resolved
pkg/core/interop_neo.go Outdated Show resolved Hide resolved
pkg/core/interop_neo_test.go Outdated Show resolved Hide resolved
pkg/core/interop_neo_test.go Outdated Show resolved Hide resolved
pkg/crypto/keys/publickey.go Outdated Show resolved Hide resolved
pkg/crypto/keys/publickey.go Outdated Show resolved Hide resolved
pkg/crypto/keys/publickey_test.go Show resolved Hide resolved
@AnnaShaleva AnnaShaleva force-pushed the interop/crypto branch 2 times, most recently from 5f0c0b4 to f89900a Compare June 3, 2020 11:12
Implement secp256k1 and secp256r1 recover interops, closes #1003.

Note:

We have to implement Koblitz-related math to recover keys properly
with Neo.Cryptography.Secp256k1Recover interop as far as standard
go elliptic package supports short-form Weierstrass curve with a=-3
only (see golang/go#26776 for details).
However, it's not the best choise to have a lot of such math in our
project, so it would be better to use ready-made solution for
Koblitz-related cryptography.
@roman-khimov roman-khimov merged commit baafa30 into neox-2.x Jun 3, 2020
@roman-khimov roman-khimov deleted the interop/crypto branch June 3, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants