-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: implement key recover interops #1006
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## neox-2.x #1006 +/- ##
============================================
+ Coverage 68.79% 68.84% +0.05%
============================================
Files 154 154
Lines 14907 14975 +68
============================================
+ Hits 10255 10310 +55
- Misses 4178 4185 +7
- Partials 474 480 +6
Continue to review full report at Codecov.
|
fyrchik
reviewed
Jun 1, 2020
a0128fa
to
2b27ee4
Compare
ed43523
to
c5e2319
Compare
fyrchik
approved these changes
Jun 2, 2020
fyrchik
previously requested changes
Jun 2, 2020
roman-khimov
requested changes
Jun 3, 2020
5f0c0b4
to
f89900a
Compare
roman-khimov
reviewed
Jun 3, 2020
Implement secp256k1 and secp256r1 recover interops, closes #1003. Note: We have to implement Koblitz-related math to recover keys properly with Neo.Cryptography.Secp256k1Recover interop as far as standard go elliptic package supports short-form Weierstrass curve with a=-3 only (see golang/go#26776 for details). However, it's not the best choise to have a lot of such math in our project, so it would be better to use ready-made solution for Koblitz-related cryptography.
f89900a
to
6c06bc5
Compare
roman-khimov
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1003