Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message to execution results #1440

Closed
roman-khimov opened this issue Sep 29, 2020 · 0 comments · Fixed by #1462
Closed

Add error message to execution results #1440

roman-khimov opened this issue Sep 29, 2020 · 0 comments · Fixed by #1462
Assignees
@AnnaShaleva
Labels
rpc RPC server and client
Milestone
v0.92.0

Comments

@roman-khimov
Copy link
Member

roman-khimov commented Sep 29, 2020 •
edited
Loading

See neo-project/neo#1885. Related to neo-project/neo-modules#334. I think we can implement the last one right away, it may be an extension if it won't be implemented in C# module, but we really need it for neo-go client invocations to show more meaningful errors.
@roman-khimov roman-khimov added the rpc RPC server and client label Sep 29, 2020
@roman-khimov roman-khimov added this to the v0.92.0 milestone Sep 29, 2020
AnnaShaleva added a commit that referenced this issue Oct 2, 2020
@AnnaShaleva
core: remove error from runtime.GetInvocationCounter
b29a43d 
close #1440
@AnnaShaleva AnnaShaleva self-assigned this Oct 5, 2020
AnnaShaleva added a commit that referenced this issue Oct 5, 2020
@AnnaShaleva
rpc: add FaultException to result.Invoke
5fb3f6f 
Close #1440
@AnnaShaleva AnnaShaleva mentioned this issue Oct 5, 2020
Merged
AnnaShaleva added a commit that referenced this issue Oct 8, 2020
@AnnaShaleva
rpc: add FaultException to result.Invoke
df03923 
Close #1440
AnnaShaleva added a commit that referenced this issue Oct 8, 2020
@AnnaShaleva
rpc: add FaultException to result.Invoke
9a493dd 
Close #1440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnnaShaleva AnnaShaleva

Labels
rpc RPC server and client
Projects
None yet
Milestone
v0.92.0
Development

Successfully merging a pull request may close this issue.

rpc, core: add FaultException to AppExecResult and Invoke* results nspcc-dev/neo-go
2 participants
@roman-khimov @AnnaShaleva