network: fix TestServerRegisterPeer data race

To prevent logs after the test ends we need to properly shutdown the
server. The problem is likely related to the fact that zap logger writes
 logs after the test ends.

 Close #2973

Signed-off-by: Ekaterina Pavlova <[email protected]>

pkg/consensus/consensus.go

@@ -296,6 +296,9 @@ func (s *service) Shutdown() {
 			s.wallet.Close()
 		}
 	}
+	if ok := s.log.Sync(); ok != nil {
+		panic("zap logger sync failed")
+	}
 }
 
 func (s *service) eventLoop() {

pkg/network/server.go

@@ -319,6 +319,10 @@ func (s *Server) Shutdown() {
 	}
 	close(s.quit)
 	<-s.relayFin
+
+	if err := s.log.Sync(); err != nil {
+		fmt.Printf("Error flushing server logs: %v\n", err)
+	}
 }
 
 // AddService allows to add a service to be started/stopped by Server.

pkg/services/oracle/oracle.go

@@ -192,6 +192,9 @@ func (o *Oracle) Shutdown() {
 	o.ResponseHandler.Shutdown()
 	<-o.done
 	o.wallet.Close()
+	if ok := o.Log.Sync(); ok != nil {
+		panic("zap logger sync failed")
+	}
 }
 
 // Start runs the oracle service in a separate goroutine.

pkg/services/rpcsrv/server.go

@@ -482,6 +482,9 @@ func (s *Server) Shutdown() {
 
 	// Wait for handleSubEvents to finish.
 	<-s.subEventsToExitCh
+	if ok := s.log.Sync(); ok != nil {
+		panic("zap logger sync failed")
+	}
 }
 
 // SetOracleHandler allows to update oracle handler used by the Server.

pkg/services/stateroot/validators.go

@@ -77,6 +77,9 @@ func (s *service) Shutdown() {
 	if s.wallet != nil {
 		s.wallet.Close()
 	}
+	if ok := s.log.Sync(); ok != nil {
+		panic("zap logger sync failed")
+	}
 }
 
 func (s *service) signAndSend(r *state.MPTRoot) error {