Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move d.lastBlockTime setting to PrepareRequest receival #55

Closed
roman-khimov opened this issue Aug 26, 2021 · 1 comment
Closed

Move d.lastBlockTime setting to PrepareRequest receival #55

roman-khimov opened this issue Aug 26, 2021 · 1 comment
Labels
enhancement Improving existing functionality I3 Minimal impact S4 Routine U4 Nothing urgent
Milestone
v0.3.2

Comments

@roman-khimov
Copy link
Member

While #46 adjusted the timer for block processing time we can try making things even better and adjust for network communication as well (as it's very significant for real networks, see nspcc-dev/neo-go#1770 as well) by carefully moving lastBlockTime setting to PrepareRequest receival. This way we only have one average message delay between this time locally and the timestamp in block header (from Primary).

It needs to be well-tested for various cases including changing views.
roman-khimov added a commit that referenced this issue Nov 29, 2021
@roman-khimov
check: set lastBlockTime in PrepareRequest handler, fix #55
288fc24 
It's the earliest point, if a view change happens the timer is reset (because
new view comes with a new set of transactions, potentially picking up ones
received between views).
@roman-khimov roman-khimov mentioned this issue Sep 26, 2023
Open
@roman-khimov roman-khimov added enhancement Improving existing functionality U4 Nothing urgent S4 Routine I3 Minimal impact labels Dec 20, 2023
@roman-khimov
Copy link
Member Author

It'd be nice to retest #56, a lot of things have changed since.

roman-khimov added a commit that referenced this issue Jun 13, 2024
@roman-khimov
check: set lastBlockTime in PrepareRequest handler, fix #55
4c7e221 
It's the earliest point, if a view change happens the timer is reset (because
new view comes with a new set of transactions, potentially picking up ones
received between views).

Signed-off-by: Roman Khimov <[email protected]>
@roman-khimov roman-khimov mentioned this issue Dec 16, 2024
Open
roman-khimov added a commit that referenced this issue Dec 25, 2024
@roman-khimov
check: set lastBlockTime in PrepareRequest handler, fix #55
279e52e 
It's the earliest point, if a view change happens the timer is reset (because
new view comes with a new set of transactions, potentially picking up ones
received between views).

Signed-off-by: Roman Khimov <[email protected]>
roman-khimov added a commit that referenced this issue Dec 31, 2024
@roman-khimov
check: set lastBlockTime in PrepareRequest handler, fix #55
42d6f59 
It's the earliest point, if a view change happens the timer is reset (because
new view comes with a new set of transactions, potentially picking up ones
received between views).

Signed-off-by: Roman Khimov <[email protected]>
@AnnaShaleva AnnaShaleva added this to the v0.3.2 milestone Jan 10, 2025
AnnaShaleva added a commit that referenced this issue Jan 10, 2025
@AnnaShaleva
Merge pull request #56 from nspcc-dev/move-lastblock-time
27db04c 
check: set lastBlockTime in PrepareRequest handler, fix #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I3 Minimal impact S4 Routine U4 Nothing urgent
Projects
None yet
Milestone
v0.3.2
Development

No branches or pull requests
2 participants
@roman-khimov @AnnaShaleva