Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support automatic authentication #300

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Conversation

jrbourbeau
Copy link
Collaborator

Closes #299, closes #283

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Binder 👈 Launch a binder notebook on this branch for commit 73b9af6

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 641eafc

Binder 👈 Launch a binder notebook on this branch for commit 335ae89

Binder 👈 Launch a binder notebook on this branch for commit 1a20f87

Binder 👈 Launch a binder notebook on this branch for commit 1cba817

Copy link
Member

@betolink betolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! I wonder if we should have a repr method to show the users if they are authenticated and if they are in us-west-2 to incorporate what @battistowx suggested in #231

@jrbourbeau
Copy link
Collaborator Author

I think that's a reasonable thing to add. Where would the repr method go? Maybe a new earthaccess.info or some better name

FWIW, while I like the repr idea, my sense is it's probably separate from the automatic login logic here (though let me know if you think otherwise)

@mfisher87
Copy link
Collaborator

FWIW, while I like the repr idea, my sense is it's probably separate from the automatic login logic here (though let me know if you think otherwise)

I'm inclined to agree here!

@mfisher87
Copy link
Collaborator

I think this is my last thought: how should this change impact the documentation?

@jrbourbeau
Copy link
Collaborator Author

how should this change impact the documentation?

I went ahead and updated the authentication section of the docs -- let me know what you think

Copy link

@MattF-NSIDC MattF-NSIDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I don't have the same level of familiarity with the library as @betolink so you may want a second opinion ;)

@jrbourbeau
Copy link
Collaborator Author

Thanks for the review @MattF-NSIDC! I'm going to go ahead and merge this in. Though happy to handle review comments from others like @betolink in a follow-up

@jrbourbeau jrbourbeau merged commit d0386ae into nsidc:main Oct 16, 2023
6 checks passed
@jrbourbeau jrbourbeau deleted the auto-login branch October 16, 2023 20:26
@mfisher87
Copy link
Collaborator

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically run earthaccess.login()? earthaccess.login() has lots of output
4 participants