Fix support for equality query on key field #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An equality check for a key field was failing with a panic if the optional project and namespace were not supplied, and with a datastore client error if they were provided.
Panic output was:
Datastore error was:
The first is fixed by defaulting the project and namespace to an empty string if not specified (a string cannot be set to
nil
).The latter is fixed by translating the
gql.KeyLiteralExpr
into adatastore.Key
in the equality branch of the query building.It's not clear from the datastore client docs what one should do with the project ID if it is specified in the
KEY(...)
GQL expression, so this is left unimplemented at present.