Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP loading function for LOLA #35

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

joseverdezoto
Copy link

No description provided.

@nsheff
Copy link
Owner

nsheff commented Jan 6, 2020

@joseverdezoto this is not passing the travis unit tests, can you look into that?

@joseverdezoto
Copy link
Author

@nsheff could you look over the changes to the loadPEPdb function? I think the previous travis unit tests warnings arose because I didn't have simplecache installed locally. It could also be that warnings were being treated as errors. Let me know if the current changes look good.

@nsheff
Copy link
Owner

nsheff commented Feb 21, 2020

I think the previous travis unit tests warnings arose because I didn't have simplecache installed locally

this was running on travis, right? your local environment would be irrelevant...

R/loadPEPdb.R Outdated Show resolved Hide resolved
R/loadPEPdb.R Outdated Show resolved Hide resolved
R/loadPEPdb.R Outdated Show resolved Hide resolved
R/loadPEPdb.R Show resolved Hide resolved
R/loadPEPdb.R Show resolved Hide resolved
R/loadPEPdb.R Show resolved Hide resolved
inst/extdata/hg19/ucsc_examplePEP/project_config.yaml Outdated Show resolved Hide resolved
R/loadPEPdb.R Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@joseverdezoto
Copy link
Author

@nsheff I made the suggested changes tested the function. The only thing I'm not sure of is how we'd include pepr as a dependency. I tried updating the DESCRIPTION file but that commit didn't pass the travis unit tests because pepr could not be installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants