Add unauthorized_entity to authenticate_for's default for called by callback

CHANGELOG.md

@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## Unreleased
+### Fixed
+- Add unauthorized_entity to authenticate_for's default for called by callback
+
 ## [2.1.1] - 2017-02-11
 ### Fixed
 - Stop trying to retrieve user from empty payload when no token is given

lib/knock/authenticable.rb

@@ -1,8 +1,12 @@
 module Knock::Authenticable
-  def authenticate_for entity_class
+  def authenticate_for entity_class, by_callback: true
     getter_name = "current_#{entity_class.to_s.parameterize.underscore}"
     define_current_entity_getter(entity_class, getter_name)
-    public_send(getter_name)
+    if by_callback
+      unauthorized_entity unless public_send(getter_name)
+    else
+      public_send(getter_name)
+    end
   end
 
   private
@@ -15,7 +19,7 @@ def method_missing(method, *args)
     prefix, entity_name = method.to_s.split('_', 2)
     case prefix
     when 'authenticate'
-      unauthorized_entity(entity_name) unless authenticate_entity(entity_name)
+      unauthorized_entity unless authenticate_entity(entity_name)
     when 'current'
       authenticate_entity(entity_name)
     else
@@ -26,11 +30,11 @@ def method_missing(method, *args)
   def authenticate_entity(entity_name)
     if token
       entity_class = entity_name.camelize.constantize
-      send(:authenticate_for, entity_class)
+      send(:authenticate_for, entity_class, by_callback: false)
     end
   end
 
-  def unauthorized_entity(entity_name)
+  def unauthorized_entity
     head(:unauthorized)
   end
 

test/dummy/app/controllers/custom_unauthorized_entity_controller.rb

@@ -7,7 +7,7 @@ def index
 
   private
 
-  def unauthorized_entity(entity)
+  def unauthorized_entity
     head :not_found
   end
 end

test/dummy/test/controllers/v1/test_namespaced_controller_test.rb

@@ -3,17 +3,25 @@
 
 module Knock
   class TestNamespacedControllerTest < ActionDispatch::IntegrationTest
-
     setup do
       @user = V1::User.first
+      @token = Knock::AuthToken.new(payload: { sub: @user.id }).token
     end
 
     test "allow namespaced models" do
-      token = Knock::AuthToken.new(payload: { sub: @user.id }).token
-      get v1_test_namespaced_index_url, headers: {'Authorization': "Bearer #{token}"}
+      get v1_test_namespaced_index_url, headers: {'Authorization': "Bearer #{@token}"}
       assert_response :ok
       assert_equal @user, @controller.current_v1_user
     end
 
+    test 'responds with unauthorized' do
+      get v1_test_namespaced_index_url
+      assert_response :unauthorized
+    end
+
+    test 'responds with unauthorized with invalid token in header' do
+      get v1_test_namespaced_index_url, headers: {'Authorization': 'Bearer invalid'}
+      assert_response :unauthorized
+    end
   end
 end