Use TypeSet for notifications so that a change in order won't cause an update #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zach-Johnson
requested changes
Apr 19, 2024
ns1/resource_notifylist.go
Outdated
Comment on lines
69
to
71
| index := 0 | ||
| if rawNotifications := d.Get("notifications").(*schema.Set); rawNotifications.Len() > 0 { | ||
| ns := make([]*monitor.Notification, rawNotifications.Len()) |
There was a problem hiding this comment.
I think if you set this to
ns := make([]*monitor.Notification, 0, rawNotifications.Len())
then you don't need to define the index separately from the for loop. Then change the additions to the slice to appends, e.g.
ns[index] = monitor.NewEmailNotification(email.(string))
// change to:
ns = append(ns, monitor.NewEmailNotification(email.(string)))
There was a problem hiding this comment.
Thanks! Going to test it next week
Zach-Johnson
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want Terraform updates that are just reordering the list; a bug upstream was partly fixed in November but null elements are still popping up when using TypeSet, so adding some safety check to exclude them.