Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring tests fixed #231

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Monitoring tests fixed #231

merged 4 commits into from
Oct 13, 2022

Conversation

eravin-ns1
Copy link
Contributor

  • Show proper use of send strings in examples - backslashes escapes are required
  • Fix monitoring job acceptance tests
$ TF_ACC=1 /usr/local/go/bin/go test -v -run TestAccMonitoring* -shuffle on
-test.shuffle 1665615565084214079
=== RUN   TestAccMonitoringJob_basic
--- PASS: TestAccMonitoringJob_basic (2.62s)
=== RUN   TestAccMonitoringJob_ManualDelete
--- PASS: TestAccMonitoringJob_ManualDelete (2.95s)
=== RUN   TestAccMonitoringJob_updated
--- PASS: TestAccMonitoringJob_updated (0.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-ns1/ns1	6.351s

@eravin-ns1 eravin-ns1 merged commit 7bd6102 into master Oct 13, 2022
@eravin-ns1 eravin-ns1 mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zach-Johnson Zach-Johnson Zach-Johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eravin-ns1 @Zach-Johnson