Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAITDS-313 #210

Merged
merged 3 commits into from
Apr 26, 2022
Merged

DAITDS-313 #210

merged 3 commits into from
Apr 26, 2022

Conversation

pcatalini
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Zach-Johnson Zach-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please write tests

ns1/provider.go Outdated Show resolved Hide resolved
@pcatalini
Copy link
Contributor Author

please write tests
it's not possible to write the test since to create a subnet we need to link with a network, and currently, we don't have the provider implemented to create the network, so we can't write the test without this provider implemented.
we have two options, first is to merge this code without a test and when we have the network implemented we can write this test, or we can block this pr create a new task to implement the network part and once it's finished, we can proceed with the test implementation.
@Zach-Johnson what are your thoughts about that?

ns1/provider.go Outdated Show resolved Hide resolved
@Zach-Johnson
Copy link
Collaborator

@pcatalini ahh, okay, we will merge this without the test then, thanks for the clarification.

@Zach-Johnson
Copy link
Collaborator

@pcatalini hmm the automated tests are still failing on make fmt 🤔

@pcatalini
Copy link
Contributor Author

@pcatalini hmm the automated tests are still failing on make fmt thinking
ops, not sure why I didn't commit properly the go fmt, however i did the corrections, thanks again

@Zach-Johnson Zach-Johnson merged commit 3bdfe3f into ns1-terraform:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants