Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAITDS-200 #181

Merged
merged 1 commit into from
Sep 17, 2021
Merged

DAITDS-200 #181

merged 1 commit into from
Sep 17, 2021

Conversation

pcatalini
Copy link
Contributor

If used metadata with an empty value in terraform file, instead of removing the previous metadata on NS1, terraform tries to apply the empty field causing an error from API. By forcing all fields to be nil if there is an empty value we can guarantee the correct behavior

Copy link
Collaborator

@Zach-Johnson Zach-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Zach-Johnson Zach-Johnson merged commit 7845215 into ns1-terraform:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants