Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mon 117 #164

Merged
merged 7 commits into from
Jul 26, 2021
Merged

Mon 117 #164

merged 7 commits into from
Jul 26, 2021

Conversation

pcatalini
Copy link
Contributor

No description provided.

mburtless
mburtless suggested changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@mburtless mburtless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really have an acceptance test for this resource_record_test.go. I'd recommend extending the existing TestAccRecord_meta case.

ns1/resource_record.go Outdated Show resolved Hide resolved
mburtless
mburtless suggested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@mburtless mburtless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcatalini - Thanks for adding acceptance tests.

Looks like there are still some formatting issues to clear up before we can merge:

gofmt needs running on the following files:
./ns1/resource_record.go

@mburtless mburtless merged commit 0bc45b4 into ns1-terraform:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburtless mburtless mburtless requested changes

@Haugum Haugum Haugum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcatalini @Haugum @mburtless