Add ability to use IPv6 monitoring jobs.

[JesseLukeWalker]

No description provided.

[Zach-Johnson]

@JesseLukeWalker this looks good to me. Before we merge can you confirm:

• The full acceptance test suite has been ran and is passing (i.e. make testacc)
• Some manual testing of this change specifically has been done to verify it works as expected, i.e. some manual test like this:
  • add the field in a terraform config
  • terraform plan and see the expected change
  • terraform apply
  • terraform plan and see that there are no changes
  • remove the field
  • terraform plan and see that the expected change to remove it
  • terraform apply
  • terraform plan and see that there are no changes

[JesseLukeWalker]

make testacc fails on origin and my branch, no matter what, with:

=== RUN   TestAccDataSourceRecord
--- FAIL: TestAccDataSourceRecord (0.20s)
    testing.go:640: Step 0 error: errors during apply:

        Error: zone does not exist

          on /tmp/tf-test657900993/main.tf line 1:
          (source code not available)

    testing.go:701: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: Check failed: record still exists: (*dns.Record)(nil) &rest.Error{Resp:(*http.Response)(0xc000874630), Message:"Not Found"}

        State: <no state>

so I can't get the tests to pass at all.

However, I can confirm that add ipv6 = true, terraform [plan/apply/plan], remove ipv6, terraform [plan/apply/plan], add ipv6 = true, terraform [plan/apply/plan], all works fine for me.

[Zach-Johnson]

lgtm, failing test is not related to this