Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(angular): remove deprecated mfe apis from app #9821

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 13, 2022

Remove deprecated MFE API from the application generator

@Coly010 Coly010 requested a review from leosvelperez April 13, 2022 12:51
@Coly010 Coly010 self-assigned this Apr 13, 2022
@vercel
Copy link

vercel bot commented Apr 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/2MWCy1L72vJNvk3kMtKPi7tp6gaj
✅ Preview: https://nx-dev-git-fork-coly010-angular-remove-mfe-app-options-nrwl.vercel.app

@vercel
Copy link

vercel bot commented Aug 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 2:54PM (UTC)

@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from cf61136 to cafa342 Compare August 13, 2022 09:47
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from cafa342 to 8e33d70 Compare August 15, 2022 09:46
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from 8e33d70 to 72016bb Compare August 15, 2022 11:52
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from 72016bb to 28b4b4d Compare August 16, 2022 14:47
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from 28b4b4d to a38c700 Compare August 17, 2022 10:17
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from a38c700 to a936d52 Compare August 17, 2022 10:24
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from a936d52 to 9e1b0d1 Compare August 17, 2022 11:42
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from 9e1b0d1 to 942c751 Compare August 17, 2022 13:27
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from 942c751 to 46f6ccc Compare August 17, 2022 14:00
@Coly010 Coly010 marked this pull request as ready for review August 17, 2022 14:15
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from 46f6ccc to 5c0f394 Compare August 18, 2022 10:17
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from 5c0f394 to 734da61 Compare August 23, 2022 13:53
@Coly010 Coly010 marked this pull request as draft August 24, 2022 10:38
@Coly010 Coly010 marked this pull request as ready for review September 20, 2022 14:23
@Coly010 Coly010 force-pushed the angular/remove-mfe-app-options branch from 734da61 to b3fb1d3 Compare September 20, 2022 14:39
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 merged commit 56957cc into nrwl:master Sep 28, 2022
@Coly010 Coly010 deleted the angular/remove-mfe-app-options branch September 28, 2022 14:55
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants