Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): projects inferrred in apps directory should be inferred as an application #9379

Conversation

AgentEnder
Copy link
Member

Current Behavior

All inferred projects have no defined projectType, which defaults to library

Expected Behavior

Projects in the apps directory should be inferred as an application

Related Issue(s)

Fixes #9374

@AgentEnder AgentEnder requested a review from FrozenPandaz March 17, 2022 13:43
@vercel
Copy link

vercel bot commented Mar 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/DArpiF2oXBF2o6htqLf9w8XabEJt
✅ Preview: https://nx-dev-git-fork-agentender-fix-infer-project-type-f-eda1f6-nrwl.vercel.app

[Deployment for 83aa061 canceled]

@nx-cloud
Copy link

nx-cloud bot commented Mar 17, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 83aa061. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder force-pushed the fix/infer-project-type-from-workspace-layout branch from 748ddb1 to 83aa061 Compare March 18, 2022 18:59
@FrozenPandaz FrozenPandaz merged commit ccfc527 into nrwl:master Mar 18, 2022
FrozenPandaz pushed a commit that referenced this pull request Mar 21, 2022
… an application (#9379)

* fix(core): projects inferrred in apps directory should be inferred as an application

* chore(repo): add jest setup back for `nx`
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx graph doesn't recognise "appsDir" as apps
2 participants