fix(storybook): ensure watch is passed to angular storybook options #8800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Hot Reload does not work with Angular 13
Expected Behavior
Hot Reload works with Angular 13
Explanation
Storybook's
app/angular/src/server/framework-preset-angular-cli.ts
file has code in it that merges three configs.It merges in the following order
angular.json/workspace.json/project.json
angularBuilderOptions
that was introduced in this commit: storybookjs/storybook@8704f84We were passing
watch: true
from our executor, but it was being overridden by thewatch
value it was reading from theangular.json/workspace.json/project.json
. This is partially because the default build configuration for Angular apps is nowproduction
.Storybook providing the
angularBuilderOptions
and merging it last gave us an option to pass thewatch
flag using it.Related Issue(s)
Fixes #8484