feat(nextjs): bump Next.js version to 12.0.7 #7788

puku0x · 2021-11-18T15:04:08Z

Current Behavior

Next.js v12.0.0 is used.

Expected Behavior

Next.js v12.0.7 is used.

Related Issue(s)

vercel · 2021-11-18T15:04:14Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/65Bd7HiEVWSpMjgMvCkzsWkWeXhj
✅ Preview: https://nx-dev-git-fork-puku0x-update-next-1204-nrwl.vercel.app

package.json

nx-cloud · 2021-11-18T15:45:24Z

Nx Cloud Report

CI ran the following commands for commit bb9749b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	`nx affected --target=e2e --base=01417d2a9bbc0d4505f00e1b4254a20f20113f3c --head=bb9749bb323fa8b382567dfe5770595e0463bd0f --exclude=e2e-react-native,e2e-detox,e2e-gatsby --parallel --max-parallel=1`
	`nx run-many --target=build --all --parallel=8`
	`nx run-many --target=build --all --parallel=8`
	`nx affected --target=build --base=01417d2a9bbc0d4505f00e1b4254a20f20113f3c --head=bb9749bb323fa8b382567dfe5770595e0463bd0f --parallel --max-parallel=3`
	`nx affected --target=test --base=01417d2a9bbc0d4505f00e1b4254a20f20113f3c --head=bb9749bb323fa8b382567dfe5770595e0463bd0f --parallel --max-parallel=3`
	`nx build typedoc-theme`

Sent with 💌 from NxCloud.

puku0x · 2021-11-19T05:30:37Z

packages/next/migrations.json

@@ -200,6 +200,19 @@
          "alwaysAddToPackageJson": false
        }
      }
+    },
+    "13.3.0": {
+      "version": "13.3.0-beta.0",


This is because Nx v13.3.0 supports the latest version of angular-eslint and I expect
it will be shipped soon. 512f094

Next.js v12.0.5+ supports ESLint v8, which means this migration is suitable for Nx v13.3.0

MitkoTschimev · 2021-11-23T11:06:54Z

Hi, everybody!

How long will it take to land into the next release?
Sorry for pushing but we really rely on this fix.

puku0x · 2021-12-06T02:26:30Z

As of v12.0.5, Next.js supports ESLint v8. I will update to the latest version (v12.0.7).
https://github.com/vercel/next.js/releases/tag/v12.0.5

puku0x · 2021-12-06T05:15:25Z

package.json

@@ -141,7 +141,7 @@
    "ejs": "^3.1.5",
    "enhanced-resolve": "^5.8.3",
    "eslint": "8.2.0",
-    "eslint-config-next": "12.0.0",
+    "eslint-config-next": "12.0.7",


yarn upgrade [email protected]

puku0x · 2021-12-06T05:15:47Z

package.json

@@ -188,7 +188,7 @@
    "mime": "2.4.4",
    "mini-css-extract-plugin": "^2.1.0",
    "minimatch": "3.0.4",
-    "next": "12.0.0",
+    "next": "12.0.7",


yarn upgrade [email protected]

puku0x · 2021-12-06T05:37:46Z

Does Next.js not allow Nx to override process.env.NODE_ENV ?
https://nx.app/runs/M1YuX0TWXjK

@kirjai I need your help to solve the build error.

packages/next/src/executors/build/build.impl.ts

puku0x · 2021-12-07T15:39:47Z

@kirjai Does Nrwl team has a plan to upgrate Next.js to 12.0.7? I think it is a great opportunity to upgrade it because Next.js v12.0.5 or later supports ESLint v8 which is the version that Nx v13.3.0 supports too.

puku0x · 2021-12-07T15:46:59Z

Something wrong in Nx Cloud? I will try it again later.

kirjai · 2021-12-07T16:32:54Z

@puku0x this is great, thanks a lot for doing the work for this! i'd suggest pushing this branch again in hopes that that was a very temporary Nx Cloud hiccup. i'm not aware of any ongoing issues with it

AgentEnder · 2021-12-07T18:00:11Z

@puku0x It looks like there is a few other locations with that NODE_ENV change, do you care to apply it in those too? 😞 I don't know why it would have just started.

puku0x · 2021-12-08T13:38:23Z

@AgentEnder Next.js recently added next/types/global.d.ts to next/index.d.ts in vercel/next.js#28316 , that's why NODE_ENV becomes readonly.

Fortunately, we don’t have to apply the cast to the others because it affects only the package using next.

puku0x · 2021-12-08T13:43:16Z

Fixed build.impl.ts and server.impl.ts.

puku0x · 2021-12-08T15:56:16Z

😕

Next.js Applications › should support Less

    Command failed: pnpx nx build app6524812 --withDeps

    DEPRECATION WARNING: --with-deps is deprecated and it will be removed in v14.
    Configure target dependencies instead: https://nx.dev/latest/angular/core-concepts/configuration#target-dependencies.
          
    Cannot read property 'oneOf' of undefined

      436 |     const pm = getPackageManagerCommand();
      437 |     let r = stripConsoleColors(
    > 438 |       execSync(`${pm.runNx} ${command}`, {
          |               ^
      439 |         cwd: opts.cwd || tmpProjPath(),
      440 |         env: { ...(opts.env || process.env), NX_INVOKED_BY_RUNNER: undefined },
      441 |         encoding: 'utf-8',

      at runCLI (../utils/index.ts:438:15)
      at src/next.test.ts:613:29
      at ../../node_modules/tslib/tslib.js:117:75
      at __awaiter (../../node_modules/tslib/tslib.js:113:16)
      at checkApp (src/next.test.ts:416:34)
      at src/next.test.ts:286:11

  ● Next.js Applications › should support Stylus

    Command failed: pnpx nx build app6633046 --withDeps

    DEPRECATION WARNING: --with-deps is deprecated and it will be removed in v14.
    Configure target dependencies instead: https://nx.dev/latest/angular/core-concepts/configuration#target-dependencies.
          
    Cannot read property 'oneOf' of undefined

      436 |     const pm = getPackageManagerCommand();
      437 |     let r = stripConsoleColors(
    > 438 |       execSync(`${pm.runNx} ${command}`, {
          |               ^
      439 |         cwd: opts.cwd || tmpProjPath(),
      440 |         env: { ...(opts.env || process.env), NX_INVOKED_BY_RUNNER: undefined },
      441 |         encoding: 'utf-8',

      at runCLI (../utils/index.ts:438:15)
      at src/next.test.ts:613:29
      at ../../node_modules/tslib/tslib.js:117:75
      at __awaiter (../../node_modules/tslib/tslib.js:113:16)
      at checkApp (src/next.test.ts:416:34)
      at src/next.test.ts:299:11

Test Suites: 1 failed, 1 total
Tests:       2 failed, 14 passed, 16 total
Snapshots:   0 total
Time:        1005.679 s
Ran all test suites.
ERROR: Something went wrong in @nrwl/run-commands - Command failed: nx run-e2e-tests e2e-next

puku0x · 2021-12-08T16:13:36Z

Something wrong with withLess and withStylus

puku0x · 2021-12-08T16:38:35Z

withLess and withStylus should search the rule as following because Next.js uses Symbols for CSS rule.

Before (v12.0.0)

const cssRule = config.module.rules.find((rule) =>
  rule.oneOf?.find((r) => r?.options?.__next_css_remove)
);

After (v12.0.5)

const cssRule = config.module.rules.find((rule) =>
  rule.oneOf?.find((r) => r?.[Symbol.for('__next_css_remove')])
);

vercel/next.js#31078

kirjai

once again, thanks a lot for doing the work for this! really appreciated

github-actions · 2023-03-19T18:05:43Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

vercel bot deployed to Preview November 18, 2021 15:04 View deployment

puku0x commented Nov 18, 2021

View reviewed changes

package.json Outdated Show resolved Hide resolved

puku0x commented Nov 18, 2021

View reviewed changes

package.json Outdated Show resolved Hide resolved

puku0x marked this pull request as ready for review November 18, 2021 15:46

puku0x force-pushed the update-next-12.0.4 branch from a38c3b8 to 21ab290 Compare November 19, 2021 05:21

vercel bot deployed to Preview November 19, 2021 05:21 View deployment

puku0x force-pushed the update-next-12.0.4 branch from 21ab290 to d8a9432 Compare November 19, 2021 05:26

vercel bot deployed to Preview November 19, 2021 05:28 View deployment

puku0x commented Nov 19, 2021

View reviewed changes

puku0x force-pushed the update-next-12.0.4 branch from d8a9432 to 4af6200 Compare November 24, 2021 14:22

vercel bot deployed to Preview November 24, 2021 14:22 View deployment

puku0x force-pushed the update-next-12.0.4 branch from 4af6200 to 385c161 Compare December 6, 2021 05:14

vercel bot deployed to Preview December 6, 2021 05:14 View deployment

puku0x changed the title ~~feat(nextjs): bump Next.js version to 12.0.4~~ feat(nextjs): bump Next.js version to 12.0.7 Dec 6, 2021

puku0x commented Dec 6, 2021

View reviewed changes

puku0x force-pushed the update-next-12.0.4 branch from 385c161 to 864d595 Compare December 7, 2021 15:30

vercel bot temporarily deployed to Preview December 7, 2021 15:30 Inactive

puku0x commented Dec 7, 2021

View reviewed changes

packages/next/src/executors/build/build.impl.ts Show resolved Hide resolved

puku0x force-pushed the update-next-12.0.4 branch from 864d595 to 8c58083 Compare December 8, 2021 13:22

vercel bot deployed to Preview December 8, 2021 13:22 View deployment

puku0x force-pushed the update-next-12.0.4 branch from 8c58083 to 8ff34ee Compare December 8, 2021 13:41

vercel bot deployed to Preview December 8, 2021 13:41 View deployment

feat(nextjs): bump Next.js version to 12.0.7

bb9749b

puku0x force-pushed the update-next-12.0.4 branch from 8ff34ee to bb9749b Compare December 8, 2021 17:04

vercel bot deployed to Preview December 8, 2021 17:04 View deployment

kirjai approved these changes Dec 8, 2021

View reviewed changes

kirjai merged commit fe96a33 into nrwl:master Dec 8, 2021

puku0x deleted the update-next-12.0.4 branch December 9, 2021 14:00

github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(nextjs): bump Next.js version to 12.0.7 #7788

feat(nextjs): bump Next.js version to 12.0.7 #7788

puku0x commented Nov 18, 2021 •

edited

Loading

vercel bot commented Nov 18, 2021 •

edited

Loading

nx-cloud bot commented Nov 18, 2021 •

edited

Loading

puku0x Nov 19, 2021 •

edited

Loading

puku0x Dec 6, 2021

MitkoTschimev commented Nov 23, 2021

puku0x commented Dec 6, 2021

puku0x Dec 6, 2021

puku0x Dec 6, 2021

puku0x commented Dec 6, 2021

puku0x commented Dec 7, 2021 •

edited

Loading

puku0x commented Dec 7, 2021

kirjai commented Dec 7, 2021

AgentEnder commented Dec 7, 2021

puku0x commented Dec 8, 2021

puku0x commented Dec 8, 2021

puku0x commented Dec 8, 2021

puku0x commented Dec 8, 2021

puku0x commented Dec 8, 2021 •

edited

Loading

kirjai left a comment

github-actions bot commented Mar 19, 2023

feat(nextjs): bump Next.js version to 12.0.7 #7788

feat(nextjs): bump Next.js version to 12.0.7 #7788

Conversation

puku0x commented Nov 18, 2021 • edited Loading

Current Behavior

Expected Behavior

Related Issue(s)

vercel bot commented Nov 18, 2021 • edited Loading

nx-cloud bot commented Nov 18, 2021 • edited Loading

Nx Cloud Report

puku0x Nov 19, 2021 • edited Loading

Choose a reason for hiding this comment

puku0x Dec 6, 2021

Choose a reason for hiding this comment

MitkoTschimev commented Nov 23, 2021

puku0x commented Dec 6, 2021

puku0x Dec 6, 2021

Choose a reason for hiding this comment

puku0x Dec 6, 2021

Choose a reason for hiding this comment

puku0x commented Dec 6, 2021

puku0x commented Dec 7, 2021 • edited Loading

puku0x commented Dec 7, 2021

kirjai commented Dec 7, 2021

AgentEnder commented Dec 7, 2021

puku0x commented Dec 8, 2021

puku0x commented Dec 8, 2021

puku0x commented Dec 8, 2021

puku0x commented Dec 8, 2021

puku0x commented Dec 8, 2021 • edited Loading

kirjai left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 19, 2023

puku0x commented Nov 18, 2021 •

edited

Loading

vercel bot commented Nov 18, 2021 •

edited

Loading

nx-cloud bot commented Nov 18, 2021 •

edited

Loading

puku0x Nov 19, 2021 •

edited

Loading

puku0x commented Dec 7, 2021 •

edited

Loading

puku0x commented Dec 8, 2021 •

edited

Loading