-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): npmrc should be obeyed during nx migrate #6781
fix(core): npmrc should be obeyed during nx migrate #6781
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/J7kaxD1n71FsDCXN1hR4uS34Sjzg [Deployment for a4e2faf canceled] |
Nx Cloud ReportCI ran the following commands for commit a4e2faf. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
f539a47
to
488ec67
Compare
488ec67
to
5210bf2
Compare
5210bf2
to
4f5aa7a
Compare
4f5aa7a
to
adda837
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor requests
adda837
to
a4e2faf
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Calling
nx migrate 'my-package'
does not obey registry settings from .npmrc. This leads to things like trying to pull latest from npm, or yarn registry instead of the registry pointed to by the workspace.If an enterprise workspace was using a private registry, and had a custom nx plugin, they would not be able to use nx migrate for their internal migration scripts.
Expected Behavior
Registries and authorization headers in .npmrc should be obeyed by
nx migrate
Workaround
Setting environment config variables does work, such as
export NPM_CONFIG_REGISTRY=....
, but these cannot be scoped to certain scopes etc.