Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix storybook-configuration not installing deps #6109

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

The @nrwl/angular:storybook-configuration generator is not installing the required deps.

Expected Behavior

The @nrwl/angular:storybook-configuration generator should install the required deps.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez added scope: angular Issues related to Angular support in Nx scope: storybook Issues related to Storybook support in Nx labels Jun 23, 2021
@leosvelperez leosvelperez self-assigned this Jun 23, 2021
@vercel
Copy link

vercel bot commented Jun 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/7beWpFpdK5CF8HFQyzoQpGnp2Pxm
✅ Preview: Canceled

[Deployment for 95e3880 canceled]

@nx-cloud
Copy link

nx-cloud bot commented Jun 23, 2021

Nx Cloud Report

CI ran the following commands for commit 95e3880. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --parallel --max-parallel=3
#000000 nx affected --target=e2e
#000000 nx affected --target=lint --parallel --max-parallel=4
#000000 nx affected --target=test --parallel --max-parallel=2
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez force-pushed the fix-ng-storybook-configuration branch from 938b10f to 95e3880 Compare June 24, 2021 08:00
@leosvelperez leosvelperez merged commit 2e4d00f into nrwl:master Jun 24, 2021
@leosvelperez leosvelperez deleted the fix-ng-storybook-configuration branch June 24, 2021 08:51
mmuenker pushed a commit to mmuenker/nx that referenced this pull request Jun 28, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: angular Issues related to Angular support in Nx scope: storybook Issues related to Storybook support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant