Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): convert scripts and styles to extra entry points #4471

Merged
merged 2 commits into from
Jan 15, 2021
Merged

fix(web): convert scripts and styles to extra entry points #4471

merged 2 commits into from
Jan 15, 2021

Conversation

armanozak
Copy link
Contributor

ISSUES CLOSED: #3730

Current Behavior

@nrwl/web schema validation fails when an object with ExtraEntryPoint type is given as scripts or styles option.

Expected Behavior

generateEntryPoints in packages/web/src/utils/third-party/cli-files/utilities/package-chunk-sort.ts expects ExtraEntryPoint for both and successfully generates entry points when ExtraEntryPoint type is given, so the validation should not fail. The type and the schema for scripts and styles appear to be outdated.

Related Issue(s)

#3730

Fixes #3730

@nx-cloud
Copy link

nx-cloud bot commented Jan 8, 2021

Nx Cloud Report

CI ran the following commands for commit 3a02a0e. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx run-many --target=build --all --parallel 1/9/2021, 12:57:24 PM
#000000 nx run-many --target=e2e --projects=e2e-next 1/9/2021, 12:59:28 PM
#000000 nx run-many --target=e2e --projects=e2e-react 1/9/2021, 1:01:19 PM
#000000 nx run-many --target=e2e --projects=e2e-web 1/9/2021, 12:58:27 PM
#000000 nx run-many --target=lint --all --parallel 1/9/2021, 12:57:14 PM

Sent with 💌 from NxCloud.

@bekos
Copy link
Contributor

bekos commented Jan 8, 2021

thx @armanozak 👍 Can you check if it is possible to write an e2e test for this functionality?

@armanozak
Copy link
Contributor Author

Hi @bekos,

I have added updated the PR with e2e tests.

@vsavkin
Copy link
Member

vsavkin commented Jan 15, 2021

Thank you!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder: @nrwl/web schema validation fails when object is given as styles option
4 participants