Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): Add quiet option for eslint #4127

Closed

Conversation

Simmyoungsub
Copy link

I current use Angular10.x with Nx.
When i run to "nx lint app -- --quiet", it is not working.
So, i fixed source code. "packages/linter/builder/eslint/utility/eslint-utils.ts"

please review this PR.
I wait for your feed back.
Thank you!

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Nov 21, 2020

Nx Cloud Report

CI ran the following commands for commit deacc99. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx build-base linter 11/21/2020, 10:59:25 AM
#000000 nx run-many --target=build --all --parallel 11/21/2020, 10:59:23 AM
#000000 nx run-many --target=e2e --projects=e2e-linter 11/21/2020, 11:00:02 AM
#000000 nx run-many --target=lint --all --parallel 11/21/2020, 11:00:55 AM
#000000 nx run-many --target=test --all --parallel 11/21/2020, 10:59:48 AM

Sent with 💌 from NxCloud.

@JamesHenry
Copy link
Collaborator

@Simmyoungsub We wouldn't be able to merge such a change without some test coverage.

In the meantime, it seems another member of the community has opened a PR looking to achieve the same thing, but there are some tests in that PR (#4330).

For that reason I am going to close this one in favour of that, as I think it's the one that gets everyone the fix the fastest, so hopefully a win all around.

Thank you very much for your contribution!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants