fix(node): use proper watch value with the node:execute executor

[CurtisHughes]

Current Behavior

When running a node app, the execute builder continues to watch for file changes when the watch mode is set to false.

"serve": {
    "builder": "@nrwl/node:execute",
    "options": {
        "buildTarget": "infra:build",
        "watch": false
    }
},

Expected Behavior

The node application to run once and exit.

Related Issue(s)

Fixes #4054

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 972de09. Click to see the status, the terminal output, and the build insights.

Status	Command	Start Time
	nx build-base angular	1/8/2021, 4:39:30 PM
	nx build-base create-nx-plugin	1/8/2021, 4:39:36 PM
	nx build-base create-nx-workspace	1/8/2021, 4:39:23 PM
	nx build-base cypress	1/8/2021, 4:39:16 PM
	nx build-base dep-graph-client --configuration release	1/8/2021, 4:38:07 PM
	nx build-base eslint-plugin-nx	1/8/2021, 4:39:23 PM
	nx build-base jest	1/8/2021, 4:39:15 PM
	nx build-base linter	1/8/2021, 4:39:15 PM
	nx build-base next	1/8/2021, 4:38:01 PM
	nx build-base nx-plugin	1/8/2021, 4:39:22 PM
	nx build-base react	1/8/2021, 4:39:50 PM
	nx build-base storybook	1/8/2021, 4:39:30 PM
	nx build-base web	1/8/2021, 4:39:30 PM
	nx build-base workspace	1/8/2021, 4:37:58 PM
	nx run-many --target=build --all --parallel	1/8/2021, 4:36:17 PM
	nx run-many --target=e2e --projects=e2e-node	1/8/2021, 4:38:13 PM
	nx run-many --target=lint --all --parallel	1/8/2021, 4:40:29 PM
	nx run-many --target=test --all --parallel	1/8/2021, 4:36:08 PM

---

Sent with 💌 from NxCloud.

[Cammisuli]

Hmm.. we'll probably need a migration for this. Existing projects should have their workspace.json updated so that watch: true is set, and doesn't break any existing expectations.

New projects will not have watch by default.

If you need help with the migration, let me know and I can guide you!

[CurtisHughes]

Sounds good, I'll take a look at adding the migration and reach out if I need any help. Thanks @Cammisuli

[CurtisHughes]

@Cammisuli I took at shot at the migration (mainly following set-build-libs-from-source.ts as a reference).

Wasn't sure what version this would fall under so I just used 10.4.5 assuming it would be in the next patch. Please let me know if I should change that to something else.

[Cammisuli]

Alright, thank you! We'll probably get this in after v11. I'll check up again soon.

[Cammisuli]

I'm finally coming around to this and I seem to have found an issue with the execute watch setting not actually working...

I'll see if I can fix it with this pr.

Thanks again for your patience!

[Cammisuli]

So I had to remove the migration because the underlying issue is actually fixed. Now we pass the proper option from the execute builder to whatever underlying builder that's being called.

I also changed a couple more things so that things are properly watched and reloaded when you do want to have watch: true

[CurtisHughes]

Nice! Thanks for pushing those changes @Cammisuli
Let me know if there is anything else that needs to be done and I can work on.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.