feat(angular): eslint config including template linting #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHenry
force-pushed
the
eslint-angular-config
branch
from
8d9e0df to
4cf501d
Compare
|
Added an additional commit with support for component and directive prefix linting based on user input/config to make it match up with TSLint |
FrozenPandaz
reviewed
Nov 6, 2020
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
For Angular projects we do not configure HTML files to be included in the
lintFilePatternsfor the@nrwl/linter:eslintbuilder and we do not include the@angular-eslinttooling to make template parsing and linting possible.We also do not have a shareable config for Angular projects to extend from.
Expected Behavior
This PR:
@angular-eslinttooling to allow for template parsing and linting, as well as Angular-specific code lint rules (official successor to Codelyzer in TSLint).angularandangular-templatelintFilePatternswhen they are generated.eslintrc.jsonfiles to the newoverridespowered structure, as discussed with Jason.#3949 unlocked our ability to add this capability because we now use
overridesat the root in latest master and can reliably instruct ESLint to use different parsers and plugins for different file-types.As usual, I have split the PR into 2 commits - (1) the code changes (2) the relevant migration
Related Issue(s)
Fixes #