fix(angular): lib was not checking importPath to parent loadChildren #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 99c1342. Click to see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud. |
FrozenPandaz
reviewed
Oct 9, 2020
packages/angular/src/schematics/library/lib/add-load-children.ts
Outdated
Show resolved
Hide resolved
…th exists loading child paths into an angular library was not checking to see if an import path exists, so it generated the wrong path. the unit tests of the angular package are working. I generated a local release with verdaccio after the correction and generated the right children path.
guiseek
force-pushed
the
fix-load-children
branch
2 times, most recently
from
b41f539 to
99c1342
Compare
FrozenPandaz
approved these changes
Oct 16, 2020
|
Thank you so much! LGTM! |
It is always pleasant when I have the opportunity to collaborate on useful projects. |
Doginal
pushed a commit
to Doginal/nx
that referenced
this pull request
Nov 25, 2020
…th exists (nrwl#3888) loading child paths into an angular library was not checking to see if an import path exists, so it generated the wrong path. the unit tests of the angular package are working. I generated a local release with verdaccio after the correction and generated the right children path.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadChildren paths into an angular library was not checking import path exists.
so it generated the wrong path.
i fixed that. the unit tests of the angular package are working.
I generated a local release with verdaccio after the correction and the right children path was generated
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #