Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular): improve incremental build speed #3854

Merged
merged 1 commit into from
Oct 30, 2020
Merged

feat(angular): improve incremental build speed #3854

merged 1 commit into from
Oct 30, 2020

Conversation

juristr
Copy link
Member

@juristr juristr commented Oct 2, 2020 •
edited
Loading

  • adds @nrwl/angular:ng-packagr-lite builder
  • improves the build speed for incremental building by reducing removing parts of ng-packagr that are not relevant for the incremental build scenario
  • --buildable flag now generates a library that uses the before mentioned builder

@nx-cloud
Copy link

nx-cloud bot commented Oct 2, 2020 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit ef3143a. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx run-many --target=build --all --parallel 10/29/2020, 9:34:11 PM
#000000 nx run-many --target=e2e --projects=e2e-angular,e2e-bazel 10/29/2020, 9:35:36 PM
#000000 nx run-many --target=e2e --projects=e2e-cypress,e2e-jest,e2e-nx-plugin 10/29/2020, 9:36:22 PM
#000000 nx run-many --target=e2e --projects=e2e-next 10/29/2020, 9:34:19 PM
#000000 nx run-many --target=e2e --projects=e2e-node 10/29/2020, 9:36:17 PM
#000000 nx run-many --target=e2e --projects=e2e-react 10/29/2020, 9:35:35 PM
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-linter,e2e-storybook 10/29/2020, 9:37:55 PM
#000000 nx run-many --target=e2e --projects=e2e-workspace,e2e-cli 10/29/2020, 9:35:18 PM
#000000 nx run-many --target=lint --all --parallel 10/29/2020, 9:35:24 PM
#000000 nx run-many --target=test --all --parallel 10/29/2020, 9:34:03 PM

Sent with 💌 from NxCloud.

@juristr juristr force-pushed the improve-ng-incremental-build-speed branch 3 times, most recently from 20e0dd6 to 71feeb3 Compare October 9, 2020 14:39
@juristr juristr force-pushed the improve-ng-incremental-build-speed branch 4 times, most recently from ba53e1a to 27a0e3c Compare October 13, 2020 22:05
juristr
juristr commented Oct 13, 2020
View reviewed changes
package.json Show resolved Hide resolved
@juristr juristr force-pushed the improve-ng-incremental-build-speed branch from 27a0e3c to 8619e29 Compare October 13, 2020 22:43
@juristr juristr marked this pull request as ready for review October 13, 2020 22:48
@juristr juristr requested a review from vsavkin October 13, 2020 22:57
@juristr juristr requested review from FrozenPandaz and removed request for vsavkin October 23, 2020 18:25
@juristr juristr assigned FrozenPandaz and unassigned vsavkin Oct 23, 2020
@juristr juristr force-pushed the improve-ng-incremental-build-speed branch 3 times, most recently from 2375001 to 5b514c3 Compare October 23, 2020 20:47
@juristr juristr force-pushed the improve-ng-incremental-build-speed branch from 051bc88 to ef3143a Compare October 29, 2020 18:54
@FrozenPandaz FrozenPandaz merged commit 0892fa2 into master Oct 30, 2020
tinesoft pushed a commit to tinesoft/nx that referenced this pull request Nov 1, 2020
@juristr @tinesoft
feat(angular): improve incremental build speed (nrwl#3854)
de5c68b
@Cammisuli Cammisuli mentioned this pull request Nov 5, 2020
Merged
@vsavkin vsavkin deleted the improve-ng-incremental-build-speed branch November 16, 2020 15:26
Doginal pushed a commit to Doginal/nx that referenced this pull request Nov 25, 2020
@juristr @Doginal
feat(angular): improve incremental build speed (nrwl#3854)
4abc727
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

Assignees

@FrozenPandaz FrozenPandaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juristr @FrozenPandaz @vsavkin