Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx): allow more types of arguments #346

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Conversation

FrozenPandaz
Copy link
Collaborator

This is a little premature but it addresses the following issues.

#339
#325

This also introduces yargs-parser as an argument parser which provides a more robust way of getting options from the cli.

Copy link
Contributor

@MarkPieszak MarkPieszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrozenPandaz
Copy link
Collaborator Author

I added tests to this so it's ready to look at

@FrozenPandaz FrozenPandaz changed the title wip: fix(nx): allow more types of arguments fix(nx): allow more types of arguments Mar 21, 2018
@vsavkin vsavkin merged commit c747a4a into nrwl:master Mar 25, 2018
@FrozenPandaz FrozenPandaz deleted the findapparg branch March 25, 2018 16:18
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants