fix(module-federation): dynamic federation helpers should normalize remote names #29427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Coly010
force-pushed
the
module-federation/normalize-manifest
branch
from
63dfcf2 to
8b462c4
Compare
|
View your CI Pipeline Execution ↗ for commit 8b462c4.
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Dec 19, 2024
ndcunningham
pushed a commit
that referenced
this pull request
Dec 20, 2024
…emote names (#29427) ## Current Behavior After migration of existing remotes beyond Nx 19.8, dynamic manifest federation files may be updated to match the normalized names of JS variables (`_` instead of `-`). Project names will not have been migrated, and therefore the logic to find the projects based on the remote names is broken. ## Expected Behavior Check the project graph for remote names as-is and by transforming `_` to `-` to see if the project exists
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
After migration of existing remotes beyond Nx 19.8, dynamic manifest federation files may be updated to match the normalized names of JS variables (
_instead of-).Project names will not have been migrated, and therefore the logic to find the projects based on the remote names is broken.
Expected Behavior
Check the project graph for remote names as-is and by transforming
_to-to see if the project exists