Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make packageExports metadata optional field #29407

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Dec 18, 2024

fix nx cloud type issue

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@nartc nartc requested a review from a team as a code owner December 18, 2024 21:04
@nartc nartc requested a review from Cammisuli December 18, 2024 21:04
@nartc nartc self-assigned this Dec 18, 2024
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 9:56pm

Copy link

nx-cloud bot commented Dec 18, 2024

View your CI Pipeline Execution ↗ for commit 8acab95.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 37m 52s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 4s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check --base=bdc76... ✅ Succeeded 22s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 22s View ↗
nx documentation --no-dte ✅ Succeeded 1m 3s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-18 22:38:23 UTC

@nartc nartc force-pushed the optional-js-packageExports branch from 4cac5f9 to 8acab95 Compare December 18, 2024 21:54
@nartc nartc merged commit 2eb5243 into master Dec 19, 2024
6 checks passed
@nartc nartc deleted the optional-js-packageExports branch December 19, 2024 02:28
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants