Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): fix misc generation issues with the ts solution setup #29350

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

leosvelperez
Copy link
Member

Fix misc generation issues related to the new TS solution setup:

  • Improve Cypress config default formatting (when no prettier)
  • Remove leftover compiler options from tsconfig.json files
  • Do not add TS path mappings
  • Update outDir for typecheck tasks to be out-tsc/...
  • Generate Nx configuration in package.json files for e2e test runner projects
  • Fix issue with @nx/js:library and --bundler=vite
  • Other smaller changes

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez requested a review from jaysoo December 13, 2024 17:23
@leosvelperez leosvelperez self-assigned this Dec 13, 2024
@leosvelperez leosvelperez requested review from a team and Coly010 as code owners December 13, 2024 17:23
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 3:12pm

Copy link

nx-cloud bot commented Dec 13, 2024

Your CI Pipeline Execution ↗ for commit 4431e86 ⏳ is in progress.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 9m, 49s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx format:check --base=012d4... ✅ Succeeded 4s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 0s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 0s View ↗
nx documentation --no-dte ✅ Succeeded 0s View ↗
nx affected -t e2e-macos-local --parallel=1 --b... ✅ Succeeded 1s View ↗

Last updated at 2024-12-16 16:23:22UTC

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez enabled auto-merge (squash) December 16, 2024 16:08
@leosvelperez leosvelperez merged commit f922e2b into master Dec 16, 2024
6 checks passed
@leosvelperez leosvelperez deleted the misc/fix-misc-ts-solution-issues branch December 16, 2024 16:23
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants