fix(core): Update move/remove workspace generators to work with ts project references #29331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Your CI Pipeline Execution ↗ for commit b4192be ⏳ is in progress.
Last updated at 2024-12-16 16:45:44UTC Sent with 💌 from NxCloud. |
ndcunningham
force-pushed
the
fix/move-remove-generators-ts-solution
branch
3 times, most recently
from
1205b0e to
d86d2df
Compare
jaysoo
reviewed
Dec 13, 2024
packages/workspace/src/utilities/typescript/ts-solution-setup.ts
Outdated
Show resolved
Hide resolved
jaysoo
reviewed
Dec 13, 2024
packages/workspace/src/generators/remove/lib/update-tsconfig.ts
Outdated
Show resolved
Hide resolved
jaysoo
reviewed
Dec 13, 2024
packages/workspace/src/generators/remove/lib/update-tsconfig.spec.ts
Outdated
Show resolved
Hide resolved
jaysoo
approved these changes
Dec 13, 2024
ndcunningham
force-pushed
the
fix/move-remove-generators-ts-solution
branch
from
5443fe0 to
b4192be
Compare
|
The flaky test for release e2e will be fixed separately, it isn't affected by this PR. Merging. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When a workspace is setup to use ts project references the move/remove generators from
@nx/workspacedo not work correctly or result in an incorrect state for the workspace.Expected Behavior
This should work OOTB.
Related Issue(s)
Fixes #